Skip to content

Fixed freezing app when receiving data#10033

Merged
keveleigh merged 5 commits into
microsoft:mainfrom
Proton-V:hotfix/correct-async-request
Jul 30, 2021
Merged

Fixed freezing app when receiving data#10033
keveleigh merged 5 commits into
microsoft:mainfrom
Proton-V:hotfix/correct-async-request

Conversation

@Proton-V

@Proton-V Proton-V commented Jun 26, 2021

Copy link
Copy Markdown
Contributor

Overview

Fixed freezing app when receiving data by Rest class

Changes

Added:

  • waiting for webRequest text
    Changes:
  • public string ResponseBody to public async Task GetResponseBody()
  • added ResponseUtils with public static Func<byte[], Task> BytesToString

fixes freezing when receiving data
@ghost

ghost commented Jun 26, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@keveleigh

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

Comment thread Assets/MRTK/Core/Utilities/WebRequestRest/Rest.cs Outdated
Comment thread Assets/MRTK/Core/Utilities/WebRequestRest/Rest.cs Outdated
@Proton-V Proton-V requested a review from keveleigh June 30, 2021 11:52
Changes in Responce struct:
-public string ResponseBody to public async Task<string> GetResponseBody()

ResponseUtils contains:
-public static Func<byte[], Task<string>> BytesToString
@david-c-kline david-c-kline added this to the MRTK 2.x future milestone Jul 6, 2021
@david-c-kline

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@david-c-kline

Copy link
Copy Markdown

@Proton-V,

This is a nice clean change.

For legacy code compat, please mark public string ResponseBody as obsolete with a note to use GetResponseBody() instead.

Thanks!

@Proton-V

Proton-V commented Jul 9, 2021

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 10033 in repo microsoft/MixedRealityToolkit-Unity

@Zee2

Zee2 commented Jul 19, 2021

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit ce92c64 into microsoft:main Jul 30, 2021
@polar-kev polar-kev modified the milestones: MRTK 2.x future, MRTK 2.7.3 Nov 22, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
…-request

Fixed freezing app when receiving data
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Apr 29, 2022
keveleigh added a commit that referenced this pull request May 19, 2022
* Revert "Merge pull request #10033 from Proton-V/hotfix/correct-async-request"

This reverts commit cd96480.

* Update DevicePortal.cs

* Re-add ResponseUtils.cs

* Update Rest.cs

* Remove breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants