Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/MixedRealityToolkit-Unity
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.8.0
Choose a base ref
...
head repository: microsoft/MixedRealityToolkit-Unity
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.8.1
Choose a head ref
  • 15 commits
  • 37 files changed
  • 8 contributors

Commits on May 31, 2022

  1. [2.8.1] Fix null ref in WindowsMixedRealityXRSDKArticulatedHand (#10622)

    * Fix null ref in WindowsMixedRealityXRSDKArticulatedHand
    
    * Update to 2.8.1
    keveleigh authored May 31, 2022
    Configuration menu
    Copy the full SHA
    7115015 View commit details
    Browse the repository at this point in the history
  2. Fixed occasional NullReferenceExceptions coming from ObjectManipulato…

    …r.OnPointerDown() (#10613)
    marek-stoj authored and keveleigh committed May 31, 2022
    Configuration menu
    Copy the full SHA
    a223741 View commit details
    Browse the repository at this point in the history
  3. Fix FollowMeToggle's auto-follow breaking if the component is disabled (

    #10620)
    
    * Fix FollowMeToggle's auto-follow breaking if the component is ever disabled
    
    `FollowMeToggle` has an `AutoFollowAtDistance` feature which breaks if the `FollowMeToggle` component is ever disabled and re-enabled. This is because the `AutoFollowAtDistance` property setter checks if the `autoFollowDistanceCheck` coroutine is null before starting the coroutine. If the component is disabled, the coroutine will _stop_ but not become null. When the component is re-enabled, the coroutine does not start again because the previous instance is non-null, even though it is no longer running.
    
    This is fixed by simply setting `autoFollowDistanceCheck` to null in `OnDisable()`.
    
    * FollowMeToggle: formatting tweak
    
    Per keveleigh
    
    Co-authored-by: Kurtis <[email protected]>
    
    Co-authored-by: Kurtis <[email protected]>
    kevinfoley and keveleigh committed May 31, 2022
    Configuration menu
    Copy the full SHA
    a1d4131 View commit details
    Browse the repository at this point in the history
  4. Fix cursors spawning at the root on initial source detection (#10623)

    pass MixedRealityPlayspace.Transform to Instantiate instead of moving on the next line
    keveleigh authored May 31, 2022
    Configuration menu
    Copy the full SHA
    fcdf493 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #10624 from keveleigh/2.8.1-cherry-picks

    2.8.1 cherry-picks from main
    keveleigh authored May 31, 2022
    Configuration menu
    Copy the full SHA
    808c439 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Configuration menu
    Copy the full SHA
    05d8a79 View commit details
    Browse the repository at this point in the history
  2. Fixed issue where Controller Visuals weren't initialized before OnSou…

    …rceDetected (#10625)
    
    * Fixed issue where Controller Visuals weren't initialized before OnSourceDetected
    
    * Update Assets/MRTK/Providers/Oculus/XRSDK/Controllers/OculusXRSDKTouchController.cs
    
    Co-authored-by: Kurtis <[email protected]>
    
    * null check
    
    Co-authored-by: Kurtis <[email protected]>
    RogPodge and keveleigh authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0edcb0b View commit details
    Browse the repository at this point in the history
  3. Fixing bug due to missing flag ifdefs (#10628)

    fixing bug due to missing flag ifdefs
    RogPodge authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    121a679 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Bounding box of SkinnedMeshRenderer support added (#10611)

    * Microsoft mandatory file (#10599)
    
    Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
    
    * Bounding box of SkinnedMeshRenderer support added
    
    * Bounding box of SkinnedMeshRenderer support added
    
    Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
    Co-authored-by: Kurtis <[email protected]>
    Co-authored-by: RogPodge <[email protected]>
    4 people authored Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c2098fd View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Update caches systems references to be actual caches and not an addit…

    …ional 0(n) lookup (#10606)
    
    * Microsoft mandatory file (#10599)
    
    Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
    
    * Update caches systems references to be actual caches and not an additional 0n lookup
    
    * Updated Reset cache implementations to also clear the individual cache references, as per request
    
    Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
    Co-authored-by: Kurtis <[email protected]>
    3 people authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    2b471d9 View commit details
    Browse the repository at this point in the history
  2. Add demand due to current image issue (port of #10642) (#10648)

    Add demand due to current image issue (#10642)
    keveleigh authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1cee188 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. [2.8.1] perf pass (#10643)

    * Remove alloc
    
    * Return early for IndexFinger
    
    * Cache .characteristics calls, which can be expensive
    
    * Return early if interaction isn't configured
    
    * Formatting
    
    * Don't call GetDevicesWithCharacteristics every frame
    
    * Use SetPositionAndRotation
    
    * Don't update ObjectManipulator twice per frame...
    
    * Cache all the InputSystem calls
    
    * Disable the line data provider if the pointer isn't active
    
    * idk sphere pointer attempt
    
    * Cache some stuff in hot loops
    
    * Rewrite ObjectManipulator to no longer use a dictionary
    
    * Fix ordering of parameters for "expected" and "actual"
    
    * Update MixedRealityServiceRegistry.cs
    
    * Change ObjectManipulator to use a list
    
    * Change back to CoreServices.InputSystem
    
    * Update FocusProvider.cs
    
    * Add some missing cases and change to else if
    
    * Convert some foreach in hot loops to a "cached end condition for loop"
    
    * Squash for loops into TryGetPointerDataWithId
    
    * Add clearer comment on why we remove only when null
    
    * Revert "Disable the line data provider if the pointer isn't active"
    
    This reverts commit 5b74c6b.
    
    * Rename lineBase to lineDataProvider
    
    * Add ProfileAnalyzer package
    keveleigh authored Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6884b43 View commit details
    Browse the repository at this point in the history
  2. Update CameraFOVChecker.cs to fix .NET build in Unity 2018 (#10654)

    Update CameraFOVChecker.cs
    keveleigh authored Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1c31885 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Configuration menu
    Copy the full SHA
    d092fa9 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Add support for "select" voice command with OpenXR (#10661)

    * Add support for "select" voice command with OpenXR
    
    * Update MicrosoftOpenXRGGVHand.cs
    MaxWang-MS authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a839860 View commit details
    Browse the repository at this point in the history
Loading