Skip to content

Add option to disable CopyFilesMarkedCopyLocal target#395

Merged
jeffkl merged 4 commits intomicrosoft:mainfrom
ViktorHofer:patch-5
Nov 7, 2022
Merged

Add option to disable CopyFilesMarkedCopyLocal target#395
jeffkl merged 4 commits intomicrosoft:mainfrom
ViktorHofer:patch-5

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer commented Oct 15, 2022 •
edited by jeffkl
Loading

This adds a new property SkipCopyFilesMarkedCopyLocal which can be set to true to disable the CopyFilesMarkedCopyLocal target.

<PropertyGroup>
  <SkipCopyFilesMarkedCopyLocal>true</SkipCopyFilesMarkedCopyLocal>
</PropertyGroup>

@ViktorHofer
Avoid copying references when NoTargetsDoNotReferenceOutputAssemblies…
bb0078e 
… is false

We use the NoTargets Sdk in multiple places in dotnet/runtime and some intentionally set NoTargetsDoNotReferenceOutputAssemblies to false so that references are calculated. This is handy when operations are performed on declared ProjectReference items. To make sure that references aren't copied to an output directory, disable the `_CopyFilesMarkedCopyLocal` target.
@ViktorHofer
Update Sdk.targets
4e5c4e4
jeffkl
jeffkl reviewed Oct 17, 2022
View reviewed changes
Comment thread src/NoTargets/Sdk/Sdk.targets Outdated
@jeffkl jeffkl changed the title Avoid copying references when NoTargetsDoNotReferenceOutputAssemblies… Add option to disable CopyFilesMarkedCopyLocal target Oct 28, 2022
ViktorHofer
ViktorHofer commented Nov 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member Author

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@jeffkl jeffkl enabled auto-merge (squash) November 7, 2022 19:45
@jeffkl jeffkl disabled auto-merge November 7, 2022 20:43
@jeffkl jeffkl merged commit 4637043 into microsoft:main Nov 7, 2022
@ViktorHofer ViktorHofer deleted the patch-5 branch November 8, 2022 07:58
This was referenced Sep 24, 2025
Merged
Open
@dependabot dependabot Bot mentioned this pull request Oct 1, 2025
Open
@dependabot dependabot Bot mentioned this pull request Nov 14, 2025
Open
@dependabot dependabot Bot mentioned this pull request Nov 24, 2025
Merged
@dependabot dependabot Bot mentioned this pull request Jan 22, 2026
Open
@dependabot dependabot Bot mentioned this pull request Mar 29, 2026
Merged
This was referenced Apr 13, 2026
Open
Open
Open
Open
Open
This was referenced Apr 22, 2026
Merged
Open
Merged
Open
This was referenced Apr 29, 2026
Open
Open
@dependabot dependabot Bot mentioned this pull request May 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffkl jeffkl jeffkl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ViktorHofer @jeffkl