display function return values #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trass3r
commented
Aug 26, 2020
| // step out | ||
| else if (reason == "function-finished") | ||
| { | ||
| string resultVar = results.Results.TryFindString("gdb-result-var"); // a gdb value history var like "$1" |
Contributor
Author
There was a problem hiding this comment.
Unfortunately we only get the name of the caller instead of the callee here.
Trass3r
commented
Aug 26, 2020
Trass3r
commented
Aug 26, 2020
Trass3r
force-pushed
the
return-values
branch
from
f9c18d9 to
e12f7db
Compare
Contributor
Author
|
@WardenGnaw |
WardenGnaw
requested changes
Sep 16, 2020
Member
WardenGnaw
left a comment
WardenGnaw
left a comment
There was a problem hiding this comment.
Will this only support return value on step-out until GDB supports getting a return value?
WardenGnaw
reviewed
Sep 17, 2020
Contributor
Author
|
Done. Yes only works on step out. |
gregg-miskelly
approved these changes
Sep 17, 2020
gregg-miskelly
requested changes
Sep 17, 2020
Trass3r
force-pushed
the
return-values
branch
from
29b0537 to
cd08c1a
Compare
Trass3r
force-pushed
the
return-values
branch
from
cd08c1a to
6797c4e
Compare
gregg-miskelly
approved these changes
Sep 17, 2020
WardenGnaw
approved these changes
Sep 18, 2020
Member
|
@Trass3r Thank you again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on gdb 8/10.
Fixes #1027.