Add support for LogPoints in OpenDebugAD7 by WardenGnaw · Pull Request #1013 · microsoft/MIEngine

WardenGnaw · 2020-06-19T00:24:08Z

This PR includes a TracepointManager for OpenDebugAD7 which will
keep track of LogMessages included in BreakpointRequests.

LogMessages can include expression inside of { } for the
engine to evaluate.

TODO: $PID since all we have is an AD_PROCESS_ID.

This PR includes a TracepointManager for OpenDebugAD7 which will keep track of LogMessages included in BreakpointRequests. LogMessages can include expression inside of { } for the engine to evaluate.

gregg-miskelly · 2020-06-19T03:48:27Z

                            breakpointRequest is AD7BreakPointRequest ad7BPRequest)

Is there a reason to maintain your own collection instead of just storing this in the breakpoint request object?

Refers to: src/OpenDebugAD7/AD7DebugSession.cs:1604 in df983e1. [](commit_id = df983e1, deletion_comment = False)

gregg-miskelly

See comments

pieandcakes · 2020-06-25T01:24:36Z

@WardenGnaw Please add an example of input/output in your original comments so we can get an idea on what the output looks like in VS Code

WardenGnaw · 2020-06-25T20:15:56Z

Example usage:

pieandcakes · 2020-06-25T21:24:46Z

Thanks for the example. Is there a way to hide that breakpoint hit message in the middle of that message?

WardenGnaw · 2020-06-25T21:26:00Z

That will be part of the logging.threadEvents flag work.

pieandcakes · 2020-06-25T21:35:59Z

        public const string TelemetrySourceFileMappings = "SourceFileMappings";
        public const string TelemetryMIMode = "MIMode";
-        public const string TelemetryStackFrameId = TelemetryExecuteInConsole + ".ExecuteInConsole";
+        public const string TelemetryStackFrameId = TelemetryExecuteInConsole + ".StackFrameId";


note: remember to classify this after its been shipped.

Same for the tracepoint one.

pieandcakes · 2020-06-26T00:06:12Z

+            }
+            catch (InvalidTracepointException e)
+            {
+                DebuggerTelemetry.ReportError(DebuggerTelemetry.TelemetryTracepointEventName, e.Message);


will this have a meaningful message? I don't remember you setting the message when you were throwing.

The only time this exception is thrown is when we cant find a matching '}' for interpolation.

pieandcakes · 2020-06-26T01:33:30Z

                        string toInterpolate = keyValuePair.Value;
-                        hr = InterpolateVariable(toInterpolate.Substring(1, toInterpolate.Length - 2), topFrame[0].m_pFrame, radix, out value);
-                        if (hr < 0)
+                        if (InterpolateVariable(toInterpolate.Substring(1, toInterpolate.Length - 2), topFrame[0].m_pFrame, radix, out value) < 0)


why not make this return value the HR? and then ...?

I did not want to stop the log message from interpolating half way through. This allows it to completly interpolate the expressions and indicate an error has occured for the ones that failed (if there are multiple)

Add support for LogPoints in OpenDebugAD7 (#1013)

Add support for LogPoints in OpenDebugAD7

df983e1

This PR includes a TracepointManager for OpenDebugAD7 which will keep track of LogMessages included in BreakpointRequests. LogMessages can include expression inside of { } for the engine to evaluate.

WardenGnaw requested review from gregg-miskelly and pieandcakes June 19, 2020 00:24

WardenGnaw self-assigned this Jun 19, 2020

gregg-miskelly reviewed Jun 19, 2020

View reviewed changes

Comment thread src/OpenDebugAD7/TracepointManager.cs Outdated