Support QuoteArgs in OpenDebugAD7#1006
Merged
WardenGnaw merged 3 commits intomasterfrom Jun 9, 2020
Merged
Conversation
This PR adds in the QuoteArgs toggle that we have in MIEngineLaunchOptions. This will toggle if we quote the debugger command or not.
pieandcakes
requested changes
Jun 8, 2020
It is only used for pipeTransport.
pieandcakes
reviewed
Jun 8, 2020
gregg-miskelly
approved these changes
Jun 8, 2020
Member
gregg-miskelly
left a comment
gregg-miskelly
left a comment
There was a problem hiding this comment.
Aside from Pierson's comment - looks good to me.
pieandcakes
approved these changes
Jun 8, 2020
WardenGnaw
added a commit
to microsoft/vscode-cpptools
that referenced
this pull request
Jun 12, 2020
With microsoft/MIEngine#1006, the debug adapter supports 'quoteArgs' in pipeTransports. If the user wishes to handle the quoting for pipeTransport arguments, they should set this field to 'false'. It currently defaults to true. For example, if quoteArgs is 'true', the pipe command will result in "bash.exe -c '/usr/bin/gdb --interpreter=mi'" If false, it will result to "wsl.exe -c /usr/bin/gdb --interpreter=mi"
WardenGnaw
added a commit
to microsoft/vscode-cpptools
that referenced
this pull request
Jun 15, 2020
With microsoft/MIEngine#1006, the debug adapter supports 'quoteArgs' in pipeTransports. If the user wishes to handle the quoting for pipeTransport arguments, they should set this field to 'false'. It currently defaults to true. For example, if quoteArgs is 'true', the pipe command will result in "bash.exe -c '/usr/bin/gdb --interpreter=mi'" If false, it will result to "wsl.exe -c /usr/bin/gdb --interpreter=mi"
WardenGnaw
added a commit
to microsoft/vscode-cpptools
that referenced
this pull request
Jun 15, 2020
With microsoft/MIEngine#1006, the debug adapter supports 'quoteArgs' in pipeTransports. If the user wishes to handle the quoting for pipeTransport arguments, they should set this field to 'false'. It currently defaults to true. For example, if quoteArgs is 'true', the pipe command will result in "bash.exe -c '/usr/bin/gdb --interpreter=mi'" If false, it will result to "wsl.exe -c /usr/bin/gdb --interpreter=mi"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in the QuoteArgs toggle that we have in
MIEngineLaunchOptions. This will toggle if we quote the debugger command
or not.
Examples:
Configuration:
Output:
1: (8103) Starting: "C:\windows\sysnative\bash.exe" -c "/usr/bin/gdb --interpreter=mi"Configuration:
Output:
1: (6374) Starting: "C:\windows\sysnative\wsl.exe" /usr/bin/gdb --interpreter=miIn this case, we will not be quoting anything at all in the arguments and it is up to the user to quote their arguments. E.g. pipeArgs: [""quoted argument with spaces""]