sema: fix string literal allowed in templates#6920
Merged
Keenuts merged 1 commit intomicrosoft:mainfrom Sep 19, 2024
Merged
Conversation
String literal are not supported in HLSL, except in the special printf case. Most cases were handled, but not the templated function case. Fixes microsoft#6877 Signed-off-by: Nathan Gauër <[email protected]>
llvm-beanz
approved these changes
Sep 18, 2024
SjMxr233
pushed a commit
to ShaderHelper/DirectXShaderCompiler
that referenced
this pull request
Jul 24, 2025
String literal are not supported in HLSL, except in the special printf case. Most cases were handled, but not the templated function case. Fixes microsoft#6877 Signed-off-by: Nathan Gauër <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String literal are not supported in HLSL, except in the special printf case.
Most cases were handled, but not the templated function case.
Fixes #6877