[SPIR-V] Remove dead code and correct Float16 docs#6127
Merged
sudonatalie merged 1 commit intomicrosoft:mainfrom Jan 4, 2024
Merged
[SPIR-V] Remove dead code and correct Float16 docs#6127sudonatalie merged 1 commit intomicrosoft:mainfrom
sudonatalie merged 1 commit intomicrosoft:mainfrom
Conversation
The docs incorrectly stated that the `SPV_AMD_gpu_shader_half_float` extension was added when half types were used. This is now corrected to show that the Float16 capability is added instead. The remaining code that could have added that extension in certain cases has been dead code since microsoft#2503 since none of the instructions checked in that list are ones that are emitted by DXC, so it is removed to clean up. Follow up from KhronosGroup/SPIRV-Tools#5519
sudonatalie
force-pushed
the
float16-docs
branch
from
4c023ce to
6779c30
Compare
Keenuts
approved these changes
Jan 4, 2024
s-perron
reviewed
Jan 4, 2024
s-perron
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs were out of date stating that the
SPV_AMD_gpu_shader_half_floatextension was added when half types were used. This is now corrected to show that the Float16 capability is added and no extension.The remaining code that could have added that extension in certain cases has been dead code since #2503 since none of the instructions checked in that list are ones that are emitted by DXC, so it is removed to clean up.
Evidence that this is dead code:
git grep "InterpolateAt"finds no uses other than those removed here.Follow-up from: KhronosGroup/SPIRV-Tools#5519