Skip to content

Add Subobjects: classes, metadata, serialization, reflection, disasm - #1621

Merged
Tex Riddell (tex3d) merged 6 commits into
microsoft:masterfrom
tex3d:dxil-subobjects
Oct 24, 2018
Merged

Add Subobjects: classes, metadata, serialization, reflection, disasm#1621
Tex Riddell (tex3d) merged 6 commits into
microsoft:masterfrom
tex3d:dxil-subobjects

Conversation

@tex3d

Copy link
Copy Markdown
Contributor

No description provided.

@AppVeyorBot

Copy link
Copy Markdown

Comment thread lib/DXIL/DxilMetadataHelper.cpp
Comment thread lib/DXIL/DxilMetadataHelper.cpp
Comment thread lib/DXIL/DxilMetadataHelper.cpp
Comment thread include/dxc/HLSL/DxilRuntimeReflection.h Outdated
Comment thread include/dxc/HLSL/DxilRuntimeReflection.h Outdated
Comment thread lib/DxilContainer/DxilContainerAssembler.cpp Outdated
Comment thread tools/clang/tools/dxcompiler/dxcdisassembler.cpp
Comment thread tools/clang/tools/dxcompiler/dxcdisassembler.cpp Outdated
Comment thread tools/clang/tools/dxcompiler/dxcdisassembler.cpp

@hekota Helena Kotas (hekota) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ehsannas

Copy link
Copy Markdown
Contributor

This change seems to break the Linux build. Please consider patching it if the fix is trivial. Thanks!

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@AppVeyorBot

Copy link
Copy Markdown

@antiagainst

Copy link
Copy Markdown
Contributor

Travis CI is happy now.

@tex3d

Copy link
Copy Markdown
Contributor Author

Thanks!

@tex3d
Tex Riddell (tex3d) merged commit 4a94258 into microsoft:master Oct 24, 2018
@tex3d
Tex Riddell (tex3d) deleted the dxil-subobjects branch October 24, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants