Skip to content

Dxil 1.4 update + packed dot intrinsics and SV_ShadingRate - #1620

Merged
Tex Riddell (tex3d) merged 4 commits into
microsoft:masterfrom
tex3d:dxil-1-4
Oct 24, 2018
Merged

Dxil 1.4 update + packed dot intrinsics and SV_ShadingRate#1620
Tex Riddell (tex3d) merged 4 commits into
microsoft:masterfrom
tex3d:dxil-1-4

Conversation

@tex3d

Copy link
Copy Markdown
Contributor

Update to DXIL 1.4 and Shader Model 6.4

Add dot2add and dot4add_*8packed intrinsics

Add SV_ShadingRate plus optional feature flag …

  • Move/fix flag collection based on signature properties to be computed
    per entry function (including for libraries)

- Move/fix flag collection based on signature properties to be computed
  per entry function (including for libraries)
@AppVeyorBot

Copy link
Copy Markdown

@ehsannas

Copy link
Copy Markdown
Contributor

This change seems to break the Linux build. Please consider patching it if the fix is trivial. Thanks!

@tex3d

Copy link
Copy Markdown
Contributor Author
      This change seems to break the Linux build. Please consider patching it if the fix is trivial. Thanks!

I'm not sure what the issue is. It says The Travis CI build passed to me. When I look into that, it looks like each individual build failed, but I can't figure out why, since it looks like it passed everything, then exits with return code 1 at the end. But the overall result says passed. I see a bunch of build warnings, but these appear to be unrelated to this change, and don't prevent the build.

@antiagainst

Copy link
Copy Markdown
Contributor

It's a sanity check we added at the early stage of supporting non-Windows systems to make sure DXIL output from the command-line is good. The check is against binaries directly, so it's gonna break every time DXIL version updates. Not really needed right now, so I removed it.

@antiagainst

Copy link
Copy Markdown
Contributor

The Travis CI is set up to allow all build jobs to fail: https://github.com/Microsoft/DirectXShaderCompiler/blob/master/.travis.yml#L36-L38.

So Travis CI will always return success no matter what.

We initially set up it this way because non-Windows support is experimental and we don't want to disturb Microsoft workflow too much. It was mainly for us to see how it goes and pay attention to non-Windows platform status so that we can fix it if something went wrong. From the experience of past few months, it seems it rarely breaks; maybe only on large changes. I'd happy to flip it as correctly showing the build status if you guys think that's fine.

@AppVeyorBot

Copy link
Copy Markdown

@antiagainst

Copy link
Copy Markdown
Contributor

Travis CI is happy now. :)

@tex3d
Tex Riddell (tex3d) merged commit d8b8789 into microsoft:master Oct 24, 2018
@tex3d
Tex Riddell (tex3d) deleted the dxil-1-4 branch October 24, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants