Properly clean up resources involved in unused convergent values. - #1616
Merged
Adam Yang (adam-yang) merged 3 commits intoOct 23, 2018
Conversation
Adam Yang (adam-yang)
requested review from
Xiang Li (python3kgae) and
Tex Riddell (tex3d)
October 20, 2018 00:29
Tex Riddell (tex3d)
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convergence annotations prevent unused instructions from being removed. Currently, resources used by of those instructions get added to the final DXIL since the instructions don't get removed until after the resources are finalized.
This change adds a DCE after removing convergence annotations and before generating final resources so no unused resources make it to the final DXIL.