Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Feb 15, 2024

Summary of the pull request

Upgrading everything to .NET 8 and handling all the syntax errors that comes with it.

References and relevant issues

#80 is in progress, but this needs to go in because DevHome is in .NET 8.

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@agniuks
Copy link

agniuks commented Feb 15, 2024

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's no longer needed.

@chenss3
Copy link

chenss3 commented Feb 15, 2024

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's no longer needed.

I opened up an issue (#81) for the previous PR (#80) that we could potentially reuse.

@dhoehna dhoehna merged commit d8bc5df into main Feb 16, 2024
@chenss3 chenss3 mentioned this pull request Feb 16, 2024
3 tasks
bbonaby pushed a commit that referenced this pull request Feb 22, 2024
* Builds. :)

* Using the out value

* Re-adding 10 to the runtimeidentifiers

* Somehow the version was commited

* Using _ to indicate not using the out parameter

* Using try* methods correctly.

---------

Co-authored-by: Darren Hoehna <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants