Remove managed vtable support on .NET 6+ #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Would this break over existing projections? |
Member
Author
|
Technically yes, but because you'll get the new Windows SDK projections along with the new CsWinRT runtime library, that will not be a problem. I talked about this with @manodasanW and he mentioned that "the only [scenario that could break] so far I can think of is if someone adds an explicit reference to CsWinRT to get the new WinRT.Runtime for some reason and are not generating a projection. If they are generating a projection, they already need to be consuming the new Windows SDK projection probably.", so it should be fine. And we really need this change to be able to drop all those unnecessary annotations 🙂 |
Sergio0694
force-pushed
the
user/sergiopedri/no-generic-vtable
branch
from
50580d3 to
dfc9824
Compare
Sergio0694
changed the base branch from
staging/AOT
to
user/sergiopedri/rcw-factory-attribute
Sergio0694
force-pushed
the
user/sergiopedri/rcw-factory-attribute
branch
from
f6d7459 to
7939f2a
Compare
Base automatically changed from
user/sergiopedri/rcw-factory-attribute
to
staging/AOT
February 21, 2024 19:35
Sergio0694
force-pushed
the
user/sergiopedri/no-generic-vtable
branch
from
dfc9824 to
e8837bf
Compare
manodasanW
reviewed
Feb 21, 2024
manodasanW
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes these main changes:
NonPublicConstructortrimming annotations aroundObjectReference<T>