Update ACHostConfig to use accessible TextBlock colors#3853
Merged
corinagum merged 11 commits intomicrosoft:masterfrom Apr 20, 2021
Merged
Update ACHostConfig to use accessible TextBlock colors#3853corinagum merged 11 commits intomicrosoft:masterfrom
corinagum merged 11 commits intomicrosoft:masterfrom
Conversation
corinagum
changed the title
corinagum
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
approved these changes
Apr 16, 2021
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Few things:
- Please run
npm install. The screenshot generated are from AC 2.5.0, but not the latest AC 2.9.0 - This file is not needed, probably generated because of earlier test failure:
__tests__/__image_snapshots__/html/transcript-activity-grouping-js-transcript-with-activity-grouping-test-50-2-snap.png
Contributor
|
Looks like there are some legit test failures. For example, since a new message is added, the scroll bar size changed. The screenshot will need to be updated.
I believe running tests locally before submitting to CI, would catch these test failures sooner. |
Contributor
Author
|
@compulim I'm running locally again to check, but this was most likely transient. I mistakenly added a command to the help command on MB that we don't want there, and then immediately removed it. I see it only failed once yesterday, around the time I made that push. The new messages button test only failed once, and the other repeating fails are timeout errors. I'll report back once I run tests locally again, but I expect them all to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
adaptiveCardHostConfigto accessible text color-contrasts, by @corinagum in PR #XXXDescription
This updates the host config to use contrast-compliant colors.
I used colors from Fabric UI color scheme to match MSFT colors.
CHANGELOG.mdI have updated documentationReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed