Skip to content
Merged
compulim merged 8 commits intomicrosoft:masterfrom
compulim:bump-ac-2.9.0
Apr 14, 2021
Merged

Bump [email protected]#3846
compulim merged 8 commits intomicrosoft:masterfrom
compulim:bump-ac-2.9.0

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Apr 14, 2021

Changelog Entry

Changed

Description

Bump Adaptive Cards to 2.9.0.

This is only bump the dependency. We will enable Action.Execute in latter PRs.

Design

Specific Changes

  • lerna add --exact --scope=botframework-webchat adaptivecards@latest
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • ~Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit a0b9e94 into microsoft:master Apr 14, 2021
@compulim compulim deleted the bump-ac-2.9.0 branch April 14, 2021 22:06
compulim added a commit that referenced this pull request Jun 22, 2021
* Bump [email protected]

* Update entry

* Update screenshots

* Fix test

* Fix test

* Fix test

* Fix tests

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants