Allow carousel's scrollable content to be tab-able with visual focus#3841
Merged
corinagum merged 13 commits intomicrosoft:masterfrom Apr 16, 2021
Merged
Allow carousel's scrollable content to be tab-able with visual focus#3841corinagum merged 13 commits intomicrosoft:masterfrom
corinagum merged 13 commits intomicrosoft:masterfrom
Conversation
corinagum
commented
Apr 10, 2021
corinagum
commented
Apr 10, 2021
corinagum
commented
Apr 10, 2021
Contributor
Author
|
3836 is merged |
compulim
reviewed
Apr 13, 2021
Contributor
compulim
left a comment
There was a problem hiding this comment.
Need some work to make it conform with CSS BEM.
compulim
approved these changes
Apr 16, 2021
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Carousel focus on children needed to be added in order to allow tabbing and AT to read contents.
Focus style will match from the following variables:
transcriptVisualKeyboardIndicatorColortranscriptVisualKeyboardIndicatorStyletranscriptVisualKeyboardIndicatorWidthSpecific Changes
#3814 - Allow carousel's scrollable content to be tab-able with visual focus
#3835 - Ensure carousel attachments are read by AT on focus
[Other]
CODEOWNERSfocusManagement.(...).htmltestCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed