Skip to content

Add type definitions for StyleOptions#3818

Merged
corinagum merged 21 commits intomicrosoft:masterfrom
corinagum:types-b
Mar 30, 2021
Merged

Add type definitions for StyleOptions#3818
corinagum merged 21 commits intomicrosoft:masterfrom
corinagum:types-b

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Mar 29, 2021 •
edited
Loading

Fixes #2100

Changelog Entry

  • Resolves #2100. Add types declarations for Style Options in api bundle, by @corinagum, in PR #3818

Description

By popular request! This set of changes provides type declarations for Web Chat's style options.

Design

Types file is exported to /types under api package.

Specific Changes

  • Clean up of StyleOption props
    • Several props were spread across two defaultStyleOptions.js :o
    • Update several props from null / empty string default value to undefined
    • Alphabetize props by category
  • Delete defaultStyleOptions.js in /component/Styles/ package
  • Add typescript linting to eslint
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread __tests__/types/typesCheck.js Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread __tests__/types/typesCheck.js
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread __tests__/types/typesCheck.js Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/api/src/index.tsx Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/bundle/src/index.ts Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/component/src/Styles/createStyleSet.ts Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/component/src/Styles/createStyleSet.ts Outdated
compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/playground/src/App.js
compulim
compulim approved these changes Mar 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

compulim
compulim reviewed Mar 29, 2021
View reviewed changes
Comment thread packages/playground/src/App.js
@corinagum corinagum merged commit a13bfd8 into microsoft:master Mar 30, 2021
@corinagum corinagum mentioned this pull request Mar 31, 2021
Merged
@schemburkar schemburkar mentioned this pull request Apr 18, 2021
Closed
@compulim compulim mentioned this pull request Jun 9, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need a way to obtain webchat.d.ts file

2 participants

@corinagum @compulim