Skip to content

4.12.1 post release#3805

Merged
corinagum merged 12 commits intomicrosoft:masterfrom
corinagum:4.12.1-post-release
Mar 23, 2021
Merged

4.12.1 post release#3805
corinagum merged 12 commits intomicrosoft:masterfrom
corinagum:4.12.1-post-release

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Mar 22, 2021

Fixes #3790

Changelog Entry

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • [N/A] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

compulim
compulim approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pin production dependencies.

For prod deps on playground and test harness, we don't need to pin them, as they are development tools.

Comment thread README.md Outdated
Comment thread packages/api/package.json Outdated
Comment thread packages/bundle/package.json Outdated
Comment thread packages/component/package.json Outdated
Comment thread packages/core/package.json Outdated
Comment thread packages/directlinespeech/package.json
Comment thread packages/embed/package.json Outdated
@corinagum corinagum force-pushed the 4.12.1-post-release branch from 4a8d0a8 to bc3d46c Compare March 23, 2021 19:01
@corinagum corinagum merged commit 416f086 into microsoft:master Mar 23, 2021
@corinagum corinagum mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Post-release checklist 4.12.1

2 participants

@corinagum @compulim