Remove replyToId for Direct Line Speech adapter#3776
Merged
compulim merged 2 commits intomicrosoft:masterfrom Mar 4, 2021
Merged
Remove replyToId for Direct Line Speech adapter#3776compulim merged 2 commits intomicrosoft:masterfrom
compulim merged 2 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
approved these changes
Mar 4, 2021
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
LGTM - wondering if we'll need to do a cherrypick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
replyToIdwhen using Direct Line Speech adapter, by @compulim in PR #3776Description
Direct Line Speech adapter does not provide send receipt or any form of ACKs. The
replyToIdwill always point to an activity outside of the transcript. Thus, a delay will always be introduced (for accessibility reasons).Since receipts or send ACKs are not supported, we could remove the
replyToIdto prevent accessibility work to introduce the delay of showing activities.Design
Specific Changes
replyToIdfor all incoming activitiesCHANGELOG.mdReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)