Skip to content

Update reaction button sample : Add replyToId to the postActivity object#3769

Merged
corinagum merged 3 commits intomicrosoft:masterfrom
amal-khalaf:amkhalaf/fix_reaction_button_sample
Mar 2, 2021
Merged

Update reaction button sample : Add replyToId to the postActivity object#3769
corinagum merged 3 commits intomicrosoft:masterfrom
amal-khalaf:amkhalaf/fix_reaction_button_sample

Conversation

@amal-khalaf
Copy link
Copy Markdown

@amal-khalaf amal-khalaf commented Mar 1, 2021

Fixes #

Reaction buttons example and activity id #3632

Changelog Entry

Description

Passes ActivityId to the Bot via the replyToId activity property

  • [ ] I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • [ ] Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • [ ] Browser and platform compatibilities reviewed
  • [ ] CSS styles reviewed (minimal rules, no z-index)
  • [ ] Documents reviewed (docs, samples, live demo)
  • [ ] Internationalization reviewed (strings, unit formatting)
  • [ ] package.json and package-lock.json reviewed
  • [ ] Security reviewed (no data URIs, check for nonce leak)
  • [ ] Tests reviewed (coverage, legitimacy)

Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the README.md for this sample, as well as the CHANGELOG.md?

Comment thread CHANGELOG.md Outdated
Comment thread samples/05.custom-components/d.reaction-buttons/README.md Outdated
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ♥

@corinagum corinagum merged commit 513e335 into microsoft:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants