Fix aria-pressed for AC submit buttons#3744
Merged
corinagum merged 17 commits intomicrosoft:masterfrom Feb 24, 2021
Merged
Conversation
amal-khalaf
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
amal-khalaf
changed the title
compulim
approved these changes
Feb 22, 2021
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
LGTM, could you update the existing entry in CHANGELOG.md to include this PR?
Co-authored-by: William Wong <[email protected]>
…rer.js Co-authored-by: William Wong <[email protected]>
compulim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixes
aria-pressedandaria-roleis not properly set on Adaptive Cards submit buttons, by @amal-khalaf in PR #3744Description
Fixed a bug that
aria-pressedandrolewas not set for buttons inside an Adaptive Card.Specific Changes
aria-pressedandroleto all buttons inside an Adaptive CardCHANGELOG.md[x] I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)