ACCESSIBILITY.md update for transcript navigation and scrolling#3721
Merged
corinagum merged 3 commits intomicrosoft:masterfrom Feb 18, 2021
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
reviewed
Feb 16, 2021
corinagum
approved these changes
Feb 16, 2021
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
LGTM! approved pending comments - lmk if you have questions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
(No changelog for doc update)
Description
Update
ACCESSIBILITY.md:I have added tests and executed them locallyI have updatedCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)