Skip to content

#3453 Fixes plain text file attachments to show download link when uploaded#3711

Merged
corinagum merged 11 commits intomicrosoft:masterfrom
corinagum:3453-fileAttachment
Feb 10, 2021
Merged

#3453 Fixes plain text file attachments to show download link when uploaded#3711
corinagum merged 11 commits intomicrosoft:masterfrom
corinagum:3453-fileAttachment

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Feb 8, 2021 •
edited
Loading

Fixes #3453

Changelog Entry

  • Fixes #3453. Fixes plain text file attachments to show download link when uploaded, by @corinagum in PR #3711

Description

Previously, attachments of type plain text were uploaded and shown as an empty bubble. This fix now shows the attachment as a download link with size listed as well.

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • [NA] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

amal-khalaf
amal-khalaf reviewed Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown

@amal-khalaf amal-khalaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one question

Comment thread packages/component/src/Middleware/AttachmentForScreenReader/createCoreMiddleware.js Outdated
compulim
compulim reviewed Feb 9, 2021
View reviewed changes
Comment thread packages/component/src/Middleware/Attachment/createCoreMiddleware.js Outdated
Comment thread packages/component/src/Middleware/AttachmentForScreenReader/TextAttachment.js Outdated
Comment thread packages/component/src/Middleware/Attachment/createCoreMiddleware.js Outdated
compulim
compulim reviewed Feb 9, 2021
View reviewed changes
Comment thread packages/component/src/Middleware/AttachmentForScreenReader/TextAttachment.js Outdated
compulim
compulim reviewed Feb 9, 2021
View reviewed changes
Comment thread packages/component/src/Middleware/AttachmentForScreenReader/createCoreMiddleware.js Outdated
compulim
compulim reviewed Feb 9, 2021
View reviewed changes
Comment thread __tests__/upload.js
@corinagum corinagum merged commit abb2203 into microsoft:master Feb 10, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@amal-khalaf amal-khalaf amal-khalaf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@compulim compulim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sending .txt or .csv file results in empty chat bubble in Web Chat, Emulator

3 participants

@corinagum @compulim @amal-khalaf