Skip to content

Adaptive card set push button aria-pressed and default push button style options#3710

Merged
amal-khalaf merged 30 commits intomicrosoft:masterfrom
amal-khalaf:amal/3622_aria_pressed
Feb 18, 2021
Merged

Adaptive card set push button aria-pressed and default push button style options#3710
amal-khalaf merged 30 commits intomicrosoft:masterfrom
amal-khalaf:amal/3622_aria_pressed

Conversation

@amal-khalaf
Copy link
Copy Markdown

@amal-khalaf amal-khalaf commented Feb 6, 2021 •
edited by cwhitten
Loading

Fixes #
#3622 [Screen Reader-Intelligent Support Experience-Feedback]: Voiceover/Talkback are not narrating the state(selected) for the buttons present in the Tell us about your experience chat while navigating using right swipe.

Changelog Entry

Fixes #3622. [Screen Reader-Intelligent Support Experience-Feedback]: Voiceover/Talkback are not narrating the state(selected) for the buttons present in the Tell us about your experience chat while navigating using right swipe, by @amal-khalaf in PR #3710

Description

Added aria-pressed=true and role=button attribute to the selected Adaptive card action button so that the AT announce which action button was pressed by the user

Setting the default background color of the selected adaptive card action button to blue

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

corinagum
corinagum reviewed Feb 8, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
corinagum
corinagum approved these changes Feb 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment

@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Feb 10, 2021

@amal-khalaf FYI it looks like this PR is missing a few snapshots, could you verify?

compulim
compulim reviewed Feb 16, 2021
View reviewed changes
Comment thread packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js Outdated
compulim
compulim requested changes Feb 16, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/StyleSet/AdaptiveCardRenderer.js Outdated
Comment thread packages/component/src/Styles/defaultStyleOptions.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/StyleSet/AdaptiveCardRenderer.js Outdated
compulim
compulim requested changes Feb 16, 2021
View reviewed changes
Comment thread packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js Outdated
compulim
compulim approved these changes Feb 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typos.

Could you also add a test (or modify the one you have) that will set the cardPushButtonBackgroundColor and cardPushButtonTextColor to a different value?

LGTM.

Comment thread packages/bundle/src/adaptiveCards/Styles/StyleSet/AdaptiveCardRenderer.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/StyleSet/AdaptiveCardRenderer.js Outdated
Comment thread packages/component/src/Styles/defaultStyleOptions.js Outdated
@amal-khalaf amal-khalaf merged commit 06ecd9f into microsoft:master Feb 18, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
Closed
52 tasks
@compulim compulim mentioned this pull request Jun 15, 2021
Closed
@compulim compulim mentioned this pull request Oct 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

+1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@amal-khalaf @corinagum @compulim @amkhalaf-github