Skip to content

Timestamp Announce limitation#3708

Merged
corinagum merged 9 commits intomicrosoft:masterfrom
amal-khalaf:amal/a11y_group_timestamp_doc
Feb 9, 2021
Merged

Timestamp Announce limitation#3708
corinagum merged 9 commits intomicrosoft:masterfrom
amal-khalaf:amal/a11y_group_timestamp_doc

Conversation

@amal-khalaf
Copy link
Copy Markdown

@amal-khalaf amal-khalaf commented Feb 4, 2021

#3616

Fixes #

Changelog Entry

Description

Adding documentation to the grouped time stamp announced limitation
where once a live region element is written to the DOM and marked with aria attribute to be logged
it is added to narration queue so even if we removed the element from the DOM later on it will still be announced.

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

Comment thread CHANGELOG.md Outdated
Comment thread docs/ACCESSIBILITY.md Outdated
Comment thread docs/ACCESSIBILITY.md Outdated
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comments!

@corinagum corinagum merged commit 9cea4cd into microsoft:master Feb 9, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants