Remove bogus aria-labelledby#3697
Merged
compulim merged 6 commits intomicrosoft:masterfrom Feb 4, 2021
Merged
Conversation
corinagum
reviewed
Feb 2, 2021
corinagum
reviewed
Feb 2, 2021
amal-khalaf
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
aria-labelledby, by @compulim in PR #3697Description
When we render an activity without text content, the
aria-labelledbyis not needed because it is referencing to the text content which does not exists.Design
The
aria-labelledbyis added for accessibility, but in some cases, such as activity without text content, we don't need it. And it's also violating accessibility if we setaria-labelledbywithout a corresponding element.Specific Changes
StackedLayout.jsnot to inject thearia-labelledbyif not neededCHANGELOG.mdI have updated documentationReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)