#3625 Update 'no screen reader for custom activity middleware' warning#3689
Merged
compulim merged 9 commits intomicrosoft:masterfrom Feb 5, 2021
Merged
#3625 Update 'no screen reader for custom activity middleware' warning#3689compulim merged 9 commits intomicrosoft:masterfrom
compulim merged 9 commits intomicrosoft:masterfrom
Conversation
corinagum
force-pushed
the
3625-AT-renderer
branch
from
0878a97 to
414e322
Compare
corinagum
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
amal-khalaf
reviewed
Feb 1, 2021
corinagum
force-pushed
the
3625-AT-renderer
branch
from
af17890 to
5dc2d8a
Compare
corinagum
commented
Feb 1, 2021
corinagum
commented
Feb 1, 2021
Contributor
Author
|
@amal-khalaf technically, there should be no visual behavioral change, but the test snapshot at |
compulim
requested changes
Feb 4, 2021
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Seems something wrong with the logic.
That code path only runs in Safari (quirks) and not in tests. So it won't catch in our CI pipeline.
compulim
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
ACCESSIBILITY.md, by @corinagum in PR #3689Description
Previously, visual activity or attachment components without an accompanying screen reader renderer threw a console error in browser. This changes that error to a warning, and adds documentation on how to suppress these warnings (not recommended).
Specific Changes
applyMiddleware.jsscreen reader console error to warning.CHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed