Skip to content

Acknowledge all activities when scroll to bottom#3684

Merged
compulim merged 6 commits intomicrosoft:masterfrom
compulim:fix-3683
Jan 29, 2021
Merged

Acknowledge all activities when scroll to bottom#3684
compulim merged 6 commits intomicrosoft:masterfrom
compulim:fix-3683

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Jan 22, 2021 •
edited
Loading

Fixes #3683.

Changelog Entry

Fixed

  • Fixes #3683. Activities should be acknowledged when user scroll to bottom, by @compulim in PR #3684

Description

Web Chat should acknowledge all activities when the user scroll to bottom.

Design

In the code:

const [sticky] = useReactScrollToBottomSticky(); // The actual code call `useAcknowledgedActivity()`, which call `useSticky()`

return (
  <ReactScrollToBottomComposer scroller={scroller}>
    ...
  </ReactScrollToBottomComposer>
);

We wrongly used the useSticky hook outside of the <ReactScrollToBottomComposer> surface.

Specific Changes

  • Adds a new internal component under the composer surface for calling useSticky
  • Proxy the scroller function out
  • Update test
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

corinagum
corinagum approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending comments

Comment thread CHANGELOG.md Outdated
Comment thread packages/component/src/BasicTranscript.js
@compulim compulim merged commit 57646e6 into microsoft:master Jan 29, 2021
@compulim compulim deleted the fix-3683 branch January 29, 2021 15:43
@compulim compulim mentioned this pull request Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@amal-khalaf amal-khalaf Awaiting requested review from amal-khalaf

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Activities not acknowledged when transcript is at the bottom

2 participants

@compulim @corinagum