Skip to content

Fixing activityMiddleware in user-highlighting sample#3671

Merged
amal-khalaf merged 4 commits intomicrosoft:masterfrom
amal-khalaf:amal/sample_fix_0.1
Jan 21, 2021
Merged

Fixing activityMiddleware in user-highlighting sample#3671
amal-khalaf merged 4 commits intomicrosoft:masterfrom
amal-khalaf:amal/sample_fix_0.1

Conversation

@amal-khalaf
Copy link
Copy Markdown

@amal-khalaf amal-khalaf commented Jan 15, 2021 •
edited
Loading

Fixes #

Changelog Entry

Fixes #3434. Dispatched event, postBack, or messageBack + activityMiddleware causes fatal error, by @amal-khalaf in PR #xxx

Description

Due to a breaking change in Web Chat v4.10. WebChat custom-components/c.user-highlighting sample was throwing TypeError

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

corinagum
corinagum reviewed Jan 19, 2021
View reviewed changes
Comment thread samples/05.custom-components/c.user-highlighting/README.md
@@ -51,15 +51,15 @@ Next, create the `activityMiddleware` which will be passed into the bot. We will
<!-- prettier-ignore-start -->
```js
Copy link
Copy Markdown
Contributor

@corinagum corinagum Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

```jsx

corinagum
corinagum approved these changes Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corinagum
Copy link
Copy Markdown
Contributor

corinagum commented Jan 19, 2021

Rerunning failed tests

@amal-khalaf amal-khalaf merged commit 0987a5d into microsoft:master Jan 21, 2021
@compulim compulim mentioned this pull request Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dispatched event, postBack, or messageBack + activityMiddleware causes fatal error

3 participants

@amal-khalaf @corinagum @amkhalaf-github