Allow implementors to change the WAI-ARIA role of the container (#3658)#3669
Allow implementors to change the WAI-ARIA role of the container (#3658)#3669corinagum merged 5 commits intomicrosoft:masterfrom
Conversation
|
Hey, thanks for the PR! I've added it to our project kanban even though it's still in draft - this is to keep it on our radar, not to pressure you on time. 🙂 |
|
Hi @corinagum, I see that BotFramework-WebChat-CI-PR has failed below Are you able to screenshot what the failure is please, or give me access or similar? Note, I'm just waiting for a response to check my understanding ...;) Many thanks, Nick |
|
@nfreear There was one failing test due to timeout as opposed to broken code. I've re-run the pipeline with the expectation that we'll get 100% pass. I'll check on it periodically and rerun if we get more timeouts. Tests now passing |
|
Thanks @corinagum ! |
|
@nfreear ping! How's it going? We'd definitely like to get your PR in when you're done with it! |
01ca716 to
953ae40
Compare
|
I updated the PR as we commented in the original issue. Instead of using
|
|
Hi @corinagum and @compulim, Apologies I left this unfinished (caught up in other work I'm afraid :() ... And, thank you for modifying @compulim -- I can see how the modifications make sense! Best wishes, Nick |
|
Totally understand about getting caught up! Similarly, we love community contributions but it's hard to fit it into our day-to-day schedule, haha. We'd love your participation in other changes if you ever have the time! Thanks again for your help. |
Changelog Entry
Added
containerRoleto default style options, by @nfreearDescription
Added a new attribute
roleto<ReactWebChat>andrenderWebChat, which allows the developer to specify the WAI-ARIA landmark role of the container for the Chat UI. It defaults tocomplementary, which is the currently hardcoded value.Design
Specific Changes
<ReactWebChat>and<BasicWebChat>to acceptroleattributecomplementaryif invalid landmark role is specifiedTests added
accessibility.landmarkRole.valid.htmlto make sure role is set correctlyaccessibility.landmarkRole.invalid.htmlto make sure role will fallback tocomplementaryCHANGELOG.md;I have updated documentationReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)