Allow <s> on sanitize markdown#3646
Merged
corinagum merged 4 commits intomicrosoft:masterfrom Dec 23, 2020
Merged
Conversation
corinagum
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
Contributor
|
Thanks for such simple tests, no need snapshots. 👍🏻 Could you add
This is |
compulim
approved these changes
Dec 22, 2020
Contributor
Author
|
@compulim neither tag passes tests - looks like Filed an issue: apostrophecms/sanitize-html#449 no tests added for latest addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
<s>on sanitize markdown, by @corinagum in PR #XXXDescription
Previously, only (deprecated)
<strike>was allowed via sanitize, but now this will allow<s>as well.markdown text
~~strikethrough~~will now render as<s>strikethrough</s>Design
Specific Changes
Add
<s>to allowed tags inrenderMarkdown.jsAdd
<del>and<ins>to allowed tags (currently causes no change in behavior; see Tags <ins> and <del> are not preserved when added to allowedTags apostrophecms/sanitize-html#449)I have added tests and executed them locally
I have updated
CHANGELOG.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed