Add suggested actions flow layout#3641
Merged
compulim merged 6 commits intomicrosoft:masterfrom Dec 24, 2020
Merged
Conversation
compulim
requested review from
a-b-r-o-w-n,
amal-khalaf,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
reviewed
Dec 18, 2020
corinagum
changed the title
corinagum
approved these changes
Dec 18, 2020
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
One question, + don't forget to rename to flow instead of inline. LGTM!
compulim
force-pushed
the
feat-suggested-actions-inline
branch
from
a87c999 to
7c14c83
Compare
compulim
changed the title
|
When will this be released? Also what is the exact usage? e.g. |
6 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
flowlayout to suggested actions, by @compulim in PR #3641Description
Added a new layout to suggested action:
inline. And a new option to curb the height of the container and make it scrollable:suggestedActionsInlineMaxHeight.Specific Changes
SuggestedActions.js, and refactoredSuggestedAction.jsto use non-flexbox for laying out images inside buttonsstyleOptions:flowoption tosuggestedActionLayoutsuggestedActionsInlineMaxHeightCHANGELOG.mdI have updated documentationReview Checklist
z-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)