Skip to content

Change ScrollToBottom role from "log" to "list"#3587

Merged
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:transcriptUlRole
Nov 4, 2020
Merged

Change ScrollToBottom role from "log" to "list"#3587
corinagum merged 4 commits intomicrosoft:masterfrom
corinagum:transcriptUlRole

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Nov 4, 2020

Fixes #3537

Changelog Entry

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum marked this pull request as ready for review November 4, 2020 20:33
@corinagum corinagum merged commit d43343c into microsoft:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility issue : Ensure aria-roledescription is only used on elements with an implicit or explicit role

2 participants