Update role for attachments#3583
Merged
compulim merged 8 commits intomicrosoft:masterfrom Nov 4, 2020
Merged
Conversation
corinagum
requested review from
a-b-r-o-w-n,
beyackle,
compulim,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
compulim
approved these changes
Nov 3, 2020
Contributor
There was a problem hiding this comment.
I think we want to "make sure all elements with aria-roledescription will have role attribute set". So I think a better test would be:
- For all elements with
aria-roledescription- Make sure they have
roleattribute set
- Make sure they have
Converting the statement to code:
const valid = [].every.call(
document.querySelectorAll('[aria-roledescription]'),
element => element.getAttribute('role')
);
expect(valid).toBe(true);Or, to find out offenders:
const invalidElements = [].find.call(
document.querySelectorAll('[aria-roledescription]'),
element => !element.getAttribute('role')
);
invalidElements.length &&
console.error('Elements with "aria-roledescription" attribute but not "role" attribute', { invalidElements });
expect(invalidElements).toHaveProperty('length', 0);
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
aria-roledescriptionis only used on elements with implicit/explicit role based off of WAI ARIA role attributes, by @corinagum in PR #3551 and #3583Description
I missed attachments.
Design
Specific Changes
-
CHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed