AC use speakProperty to narrate and hide error box#3573
Merged
compulim merged 5 commits intomicrosoft:masterfrom Nov 3, 2020
Merged
AC use speakProperty to narrate and hide error box#3573compulim merged 5 commits intomicrosoft:masterfrom
compulim merged 5 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
corinagum
reviewed
Nov 2, 2020
corinagum
approved these changes
Nov 2, 2020
This was referenced Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
speakproperty should be narrated in screen reader, by @compulim in PR #3573Description
For better narration of Adaptive Card, we should narrate using the
speakproperty, as stated in Adaptive Card schema.We should also hide the red error box when Adaptive Card renderer failed in production mode.
Design
Specific Changes
speakpropertyAdaptiveCardRenderer.jsto hide the<ErrorBox>when running in production modeCHANGELOG.mdReview Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)