Skip to content

Add explicit role to stacked layout message#3551

Merged
compulim merged 5 commits intomicrosoft:masterfrom
corinagum:3537
Oct 24, 2020
Merged

Add explicit role to stacked layout message#3551
compulim merged 5 commits intomicrosoft:masterfrom
corinagum:3537

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Oct 20, 2020 •
edited
Loading

Fixes #3537

Changelog Entry

Description

  • Accessibility Insights for Web showed messages as having no implicit/explicit role. This change adds explicit role="group" to messages.
  • Although WAI-ARIA indicates that role="group" can have a child role="listitem", Accessibility Insights files the pattern as an a11y bug.
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum marked this pull request as ready for review October 20, 2020 23:15
compulim
compulim previously requested changes Oct 20, 2020
View reviewed changes
Comment thread packages/component/src/Activity/StackedLayout.js Outdated
compulim
compulim reviewed Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test too.

Comment thread packages/component/src/Activity/StackedLayout.js Outdated
@corinagum corinagum dismissed compulim’s stale review October 21, 2020 22:34

Comments addressed

compulim
compulim reviewed Oct 21, 2020
View reviewed changes
Comment thread packages/component/src/Activity/StackedLayout.js Outdated
@compulim compulim merged commit 0e3381d into microsoft:master Oct 24, 2020
@compulim compulim deleted the 3537 branch October 24, 2020 09:01
@compulim compulim mentioned this pull request Oct 29, 2020
Closed
48 tasks
This was referenced Nov 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim left review comments

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessibility issue : Ensure aria-roledescription is only used on elements with an implicit or explicit role

3 participants

@corinagum @cwhitten @compulim