Skip to content

Fix PoliCheck (security updates)#3545

Merged
corinagum merged 8 commits intomicrosoft:masterfrom
corinagum:3514-PoliCheck
Oct 21, 2020
Merged

Fix PoliCheck (security updates)#3545
corinagum merged 8 commits intomicrosoft:masterfrom
corinagum:3514-PoliCheck

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Oct 16, 2020 •
edited
Loading

Fixes #3514

Changelog Entry

Description

Updated certain terminology to pass cultural etc. rules.

  • [ ] I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum changed the title 3514 poli check Fix PoliCheck (security updates) Oct 16, 2020
@corinagum corinagum marked this pull request as ready for review October 16, 2020 20:49
compulim
compulim reviewed Oct 20, 2020
View reviewed changes
Comment thread CHANGELOG.md Outdated
compulim
compulim reviewed Oct 20, 2020
View reviewed changes
Comment thread packages/component/src/Styles/defaultStyleOptions.js Outdated
@corinagum
Copy link
Copy Markdown
Contributor Author

corinagum commented Oct 21, 2020

https://fuselabs.visualstudio.com/BotFramework-WebChat/_build/results?buildId=177008&view=results passed, so I'm squash merging (status still says checks were not successful)

@corinagum corinagum merged commit 98cbff3 into microsoft:master Oct 21, 2020
@compulim compulim mentioned this pull request Oct 29, 2020
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SDLC security tool PoliCheck

2 participants

@corinagum @compulim