Skip to content

Fix bot initials being undefined in AT text#3524

Merged
corinagum merged 1 commit intomicrosoft:masterfrom
corinagum:3489-bot-initials-said
Oct 6, 2020
Merged

Fix bot initials being undefined in AT text#3524
corinagum merged 1 commit intomicrosoft:masterfrom
corinagum:3489-bot-initials-said

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Oct 6, 2020

Fixes #3489

Changelog Entry

Description

Specific Changes

Previously, bot initials were being said as undefined if initials have not been assigned.

  • Change already present for CarouselFilmStrip and StackedLayout
  • Therefore, only added for ScreenReaderActivity
  • NOTE: accessibility issue; currently no test framework

- [ ] I have added tests and executed them locally

  • I have updated CHANGELOG.md
    - [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum merged commit 175a3df into microsoft:master Oct 6, 2020
@compulim compulim mentioned this pull request Oct 29, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assistive technologies start reading Bot message with "Bot undefined said"

2 participants