Fixes #3439
Fixes #2693

Changelog Entry

• Fixes #3439. Use consistent return type in default CardActionContext.getSignInUrl(), by @stevengum in PR #3459

Description

DirectLine instances/objects that do not implement getSessionId() results in a codepath that returns a string when the calling code expects a Promise.resolve(). This PR wraps the changes the default CardActionContext.getSignInUrl() to always return Promise.resolve(), regardless of whether or not the DirectLine object implements getSessionId().

Specific Changes

• Update getSignInUrl() to have consistent return type (Promise<string>)
• Update warning message when directLine.getSessionId is falsy in the default CardActionContextMiddleware to indicate no-magic-code OAuth flows are not supported
• Add test for CardActionContextMiddleware changes
• Add disableNoMagicCode option to __tests__/setup/web/index.html for testing bugfix
• Add getConsoleErrors() and getConsoleWarnings() to pageObjects
• Refactor speech.synthesis.js to use getConsoleErrors() instead of getConsoleLogs()
• Add internal helper consoleLogFlattener() for flattening the data structure returned in getConsoleErrors() and getConsoleWarnings()
  • getConsoleLogs() still returns Array<Array<string>> e.g.
    • [["error", "error-message"], ["warn", "some-warning-message"]]
  • getConsoleErrors() and getConsoleWarnings() returns <Array<string>, e.g.
    • ["error-message"] or ["some-warning-message"].

Repro steps

1. Connect to bot using a DirectLineStreaming connection (i.e., DL-ASE, DLS)
2. Begin OAuth flow in bot
3. Click on login button, observe new tab open without a login URL
4. Go back to Web Chat tab, open console and see following error:
   

• [ ] I have added tests and executed them locally Incomplete
• I have updated CHANGELOG.md
• [ ] I have updated documentation Not applicable

Review Checklist

This section is for contributors to review your work.

• Accessibility reviewed (tab order, content readability, alt text, color contrast)
• Browser and platform compatibilities reviewed
• CSS styles reviewed (minimal rules, no z-index)
• Documents reviewed (docs, samples, live demo)
• Internationalization reviewed (strings, unit formatting)
• package.json and package-lock.json reviewed
• Security reviewed (no data URIs, check for nonce leak)
• Tests reviewed (coverage, legitimacy)