Skip to content

Bump [email protected] in samples/06.recomposing-ui/c.smart-display#3458

Merged
compulim merged 2 commits intomasterfrom
fix-sample-iconv
Sep 9, 2020
Merged

Bump [email protected] in samples/06.recomposing-ui/c.smart-display#3458
compulim merged 2 commits intomasterfrom
fix-sample-iconv

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Sep 9, 2020 •
edited
Loading

Fixes CD pipeline.

Changelog Entry

Samples

Description

[email protected] is causing issues in our CD pipeline because the way it resolve iconv-lite and Webpack is giving warning that would trigger an error in CD pipeline. See andris9/encoding#18.

Excerpt of the problematic code:

'use strict';

var iconv_package;
var Iconv;

try {
    // this is to fool browserify so it doesn't try (in vain) to install iconv.
    iconv_package = 'iconv';
    Iconv = require(iconv_package).Iconv;
} catch (E) {
    // node-iconv not present
}

And it caused an error:

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

./node_modules/encoding/lib/iconv-loader.js
Critical dependency: the request of a dependency is an expression

Design

Bumped from encoding@^0.1.11 (actual 0.1.12) to [email protected].

Specific Changes

  • Updated samples/06.recomposing-ui/c.smart-display/package-lock.json to use [email protected]
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit b4eca64 into master Sep 9, 2020
@compulim compulim deleted the fix-sample-iconv branch September 9, 2020 02:41
@compulim compulim mentioned this pull request Sep 9, 2020
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srinaath srinaath srinaath approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@compulim @srinaath