Skip to content

[Post 4.10.1] Fix suggested actions maxHeight#3456

Merged
corinagum merged 6 commits intomicrosoft:masterfrom
corinagum:3444
Sep 11, 2020
Merged

[Post 4.10.1] Fix suggested actions maxHeight#3456
corinagum merged 6 commits intomicrosoft:masterfrom
corinagum:3444

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented Sep 8, 2020

Fixes #3444

Changelog Entry

  • Fixes #3444. Make suggested actions container height styleOption flexible, by @corinagum in PR #XXX

Description

Suggested Actions height was set to static, causing issues if assigned height was different than stacked height of all buttons. This fixes the height style option to be assigned to maxHeight

Design

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

compulim
compulim approved these changes Sep 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for testing corner cases.

Comment thread packages/component/src/Styles/StyleSet/SuggestedActions.js Outdated
@compulim compulim changed the title Fix suggested actions maxHeight [Post 4.10.1] Fix suggested actions maxHeight Sep 8, 2020
@compulim
Copy link
Copy Markdown
Contributor

compulim commented Sep 8, 2020

Please don't merge until after 4.10.1. 🙏🏻

@corinagum corinagum merged commit 681e8b7 into microsoft:master Sep 11, 2020
@corinagum corinagum mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suggested Actions container height is not flexible

2 participants

@corinagum @compulim