[Target 4.10.1] Fix first delay of activity#3450
Merged
compulim merged 3 commits intomicrosoft:masterfrom Sep 4, 2020
Merged
Conversation
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
approved these changes
Sep 3, 2020
Contributor
corinagum
left a comment
There was a problem hiding this comment.
Approved, pending a couple comments.
Co-authored-by: Corina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
replyToIdpointing to a missing activity, by @compulim in PR #XXXDescription
When the first activity arrives, it always comes with a random
replyToId, despite it is not actually replying to any conversation. This is a limitation of the design of SDK.To mitigate the issue, Web Chat cannot delay the first (group of) activities even though the
replyToIdproperty is pointing to a potentially-transmitting activity.Design
Please see the updated
ACCESSIBILITY.mdfor details.Specific Changes
queueIncomingActivitySaganot to hold the activity if one of the following is true:replyToIdis already renderedCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewed