[Target 4.10.1] Support Content Security Policy#3443
Merged
compulim merged 23 commits intomicrosoft:masterfrom Sep 4, 2020
Merged
[Target 4.10.1] Support Content Security Policy#3443compulim merged 23 commits intomicrosoft:masterfrom
compulim merged 23 commits intomicrosoft:masterfrom
Conversation
corinagum
reviewed
Sep 2, 2020
corinagum
reviewed
Sep 2, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
reviewed
Sep 3, 2020
corinagum
approved these changes
Sep 3, 2020
Contributor
corinagum
left a comment
There was a problem hiding this comment.
approved pending a couple comments
Co-authored-by: Corina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
glamoris being replaced bycreate-emotion. The CSS hash and rule name is being prefixed withwebchat--csswith a random value.Changed
[email protected]to[email protected]blob:scheme, instead ofdata:schemewindow.MessagePortandwindow.Workerblob:[email protected][email protected]Samples
Description
This feature enables Web Chat to be embedded on a page with Content Security Policy enabled.
Design
Please refer to
CONTENT_SECURITY_POLICY.mdfor design.Specific Changes
nonce<style>element, but not<img>and other media tags (see/vote [Content Security Policy] Addnoncesupport for<img>and other tags #3445)glamortocreate-emotioncss-*towebchat--css-xxxxx-*blob:scheme, instead ofdata:schemeimg-src data:is insecureblob:window.Worker[email protected][email protected]useStyleToEmotionObjectto convert from object style toemotionobjectemotionas part of our long-term dependency, this is also true forglamorand most of our dependenciesuseNoncefornoncepropCHANGELOG.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed