Fix #3354 Adding access key to suggested actions#3367
Merged
compulim merged 16 commits intomicrosoft:masterfrom Aug 1, 2020
Merged
Fix #3354 Adding access key to suggested actions#3367compulim merged 16 commits intomicrosoft:masterfrom
compulim merged 16 commits intomicrosoft:masterfrom
Conversation
tdurnford
reviewed
Jul 31, 2020
tdurnford
reviewed
Jul 31, 2020
tdurnford
reviewed
Jul 31, 2020
tdurnford
reviewed
Jul 31, 2020
tdurnford
reviewed
Jul 31, 2020
tdurnford
reviewed
Jul 31, 2020
tdurnford
approved these changes
Jul 31, 2020
Co-authored-by: TJ Durnford <[email protected]>
Co-authored-by: TJ Durnford <[email protected]>
36db80e to
5d36368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
Adding access key to suggested actions. Screen reader texts are updated to reflect this change.
Instead of using HTML's
accesskeyattribute, we are using our own implementation for a few reasons:Specific Changes
AccessKeySinkto handle the sinking ofkeyupevents related to access keysuseFocusAccessKeyEffecthook for handling access key for focusingsuggestedActionsAccessKeyprop to<Composer>useLocalizeAccessKeyhook to localize access key into stringuseNavigatorPlatformhook to identify platformen-US.jsonandyue.jsonfor new loc stringsAdditional Context
__tests__/suggestedActions.jsOne of the original snapshot for
__tests__/suggestedActions.jsis incorrect. It produce the following result whenstyleOptionsis set to{ suggestedActionLayout: 'stacked', suggestedActionsStackedHeight: 50 }.We should not render wrong layout with default style options. We should also put some efforts to make sure devs can't mess up the UI too far.