Activity grouping feature#3365
Merged
beyackle merged 100 commits intomicrosoft:masterfrom Jul 31, 2020
Merged
Conversation
0305f7a to
4bda6d8
Compare
beyackle
suggested changes
Jul 29, 2020
Contributor
beyackle
left a comment
There was a problem hiding this comment.
Some legibility issues, but overall I like how this looks.
| // ) => React.Element | ||
|
|
||
| return function renderCarouselLayout(renderAttachment, props) { | ||
| typeof props === 'undefined' && |
Contributor
Author
|
Thanks for your review. Still prefer As many JS developers are familiar with these shortcuts and truthy/falsy values, I don't see readability as a big concern here. |
beyackle
approved these changes
Jul 31, 2020
Contributor
beyackle
left a comment
There was a problem hiding this comment.
Thanks for clearing up the motivation behind the syntax that, to my eyes, still looks strange. I trust your specs, though, and the fixes you made look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still in draft mode, running tests on Azure DevOps.
Changelog Entry
Description
useCreateActivityRendererwill replaceuseRenderActivityuseCreateActivityStatsuRendererwill replaceuseRenderActivityStatus40pxNew
createRenderActivityhookThe old signature is:
The new signature is:
New
createRenderActivityStatushookThe old signature is:
The new signature is:
Specific Changes
Screenshot changes
There are 5 types of screenshot changes:
transcript.*.html,activityGrouping.*.htmlhooks.useCreate*.html,hooks.useRender*.htmlAdditional context
How it works
Font anti-alias
Updating many screenshots because of anti-alias. Cause is unknown but usually caused by bumping versions of Docker + Chrome.
Pixel-perfect carousel layout
Green layer is the old stacked layout (also same as the new carousel layout).
Red layer is the old carousel layout, which is a 1-2px offset from the old stacked layout.
We updated the carousel layout so it will align with the stacked layout for consistency. We chose stacked layout because it is the default layout.