Skip to content

Fix blank screen on rendering red box#3295

Merged
compulim merged 1 commit intomicrosoft:masterfrom
compulim:fix-3294
Jul 8, 2020
Merged

Fix blank screen on rendering red box#3295
compulim merged 1 commit intomicrosoft:masterfrom
compulim:fix-3294

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Jul 7, 2020

Fixes #3294.

Changelog Entry

Fixed

Description

Fixed blank screen on missing middleware.

Specific Changes

  • Update all createXxxMiddleware to import React

  • Testing Added
    • Tests will be added in a separate PR

@compulim compulim merged commit 746124f into microsoft:master Jul 8, 2020
@compulim compulim deleted the fix-3294 branch July 8, 2020 00:43
compulim added a commit that referenced this pull request Jul 8, 2020
@compulim compulim mentioned this pull request Jul 13, 2020
42 tasks
@compulim
Copy link
Copy Markdown
Contributor Author

For manual testing:

  • Click "Send all commands" button
  • It should complete successfully (instead of blank screen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blanked out when rendering attachment without a registered renderer

2 participants