Skip to content

Added support for Redux Devtools#3277

Merged
compulim merged 3 commits intomicrosoft:masterfrom
tpdewolf:feature/redux-devtools
Aug 10, 2020
Merged

Added support for Redux Devtools#3277
compulim merged 3 commits intomicrosoft:masterfrom
tpdewolf:feature/redux-devtools

Conversation

@tpdewolf
Copy link
Copy Markdown
Contributor

@tpdewolf tpdewolf commented Jun 24, 2020

Changelog Entry

Added

Description

Composed the redux store with the redux devtools enchancer. This makes it easier to debug the state.

Specific Changes

From:

const store = createStore(reducer, initialState || {}, applyMiddleware(...middlewares, sagaMiddleware));

To:

const store = createStore(
    reducer,
    initialState || {},
    composeWithDevTools(applyMiddleware(...middlewares, sagaMiddleware))
  );
  • Testing Added
    No tests added

@ghost
Copy link
Copy Markdown

ghost commented Jun 24, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@compulim compulim self-assigned this Jun 24, 2020
@compulim
Copy link
Copy Markdown
Contributor

compulim commented Aug 5, 2020

@tpdewolf before we can accept your contribution, could you read the Contributor License Agreement?

@compulim
Copy link
Copy Markdown
Contributor

compulim commented Aug 9, 2020 •
edited
Loading

I have updated the code with the following changes:

  • Moved Redux DevTools as an opt-in feature (createStore -> createStoreWithDevTools)
  • Expose DevTools "endpoint" in NPM package only
    • We don't have development favor of bundle (yet)
  • Added docs on disclaimer, code snippet, and limitations
  • Updated playground to support Redux DevTools
  • Use exact version for production dependencies

@compulim compulim force-pushed the feature/redux-devtools branch from 7a66ea4 to e3397fa Compare August 9, 2020 15:17
@compulim compulim merged commit 284339c into microsoft:master Aug 10, 2020
@tpdewolf tpdewolf deleted the feature/redux-devtools branch August 10, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@compulim compulim

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tpdewolf @compulim