Saving and restoring scroll position in composition mode#3268
Merged
compulim merged 17 commits intomicrosoft:masterfrom Jun 25, 2020
Merged
Saving and restoring scroll position in composition mode#3268compulim merged 17 commits intomicrosoft:masterfrom
compulim merged 17 commits intomicrosoft:masterfrom
Conversation
aadce8a to
344bc56
Compare
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
reviewed
Jun 23, 2020
tdurnford
approved these changes
Jun 23, 2020
Co-authored-by: TJ Durnford <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
useObserveScrollPositionanduseScrollTohooks, by @compulim in PR #3268<ReactWebChat>into<Composer>and<BasicWebChat>, by @compulim in PR #3268Samples
Description
New hooks to observe and restore scroll positions.
To enable hooks outside of Web Chat UI, we added a new sample to enable composition mode.
To enable composition mode, this PR will fix #2859 by enabling middleware in
<Composer>.useObserveScrollPositionThis function accept an observer function. When the scroll position has changed, the observer function will be called with the latest
ScrollPosition.The
positionargument can be passed touseScrollTohook to restore scroll position.Since the observer function will be called rapidly, please keep the code in the function as lightweight as possible.
To stop observing scroll positions, pass a falsy value to the
observerargument.useScrollToThis function will return a function that, when called, will scroll the transcript to the specific scroll position.
If
optionsis passed withbehaviorset tosmooth, it will smooth-scrolling to the scroll position. Otherwise, it will jump to the scroll position instantly.Specific Changes
<ReactWebChat>is now comprised from<Composer>and<BasicWebChat><Composer>to fix Code: MovecreateXXXRendererinto<Composer>#2859useObserveScrollPositionanduseScrollTohooksreact-scroll-to-bottom04.api/d.post-activity-eventto use composition mode