Skip to content

Add Direct Line App Service Extension protocol#3206

Merged
compulim merged 10 commits intomicrosoft:masterfrom
compulim:feat-dlase
Jun 8, 2020
Merged

Add Direct Line App Service Extension protocol#3206
compulim merged 10 commits intomicrosoft:masterfrom
compulim:feat-dlase

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Jun 5, 2020 •
edited
Loading

Fixes #3205.

Changelog Entry

Added

Changed

Samples

Description

Add Direct Line App Service Extension chat adapter.

Specific Changes

  • Bundled the adapter through createDirectLineAppServiceExtension
    • Exposed in both bundle and NPM
    • As this is built into DirectLineJS, it is supported in minimal bundle
  • Added sample for Direct Line App Service Extension chat adapter
  • Bumped to [email protected]
  • Removing some tests as they are already migrated to the new HTML-based tests
  • Migrated some tests to HTML-based instead of fixing them
    • New pageObjects.waitWithTick() to run lolex.tick(1) while waiting
  • Testing Added

@compulim compulim marked this pull request as ready for review June 5, 2020 00:24
@compulim
Copy link
Copy Markdown
Contributor Author

compulim commented Jun 5, 2020

After this is merged, please update https://docs.microsoft.com/en-us/azure/bot-service/bot-service-channel-directline-extension-webchat-client?view=azure-bot-service-4.0.

corinagum
corinagum reviewed Jun 5, 2020
View reviewed changes
Comment thread samples/01.getting-started/i.protocol-direct-line-app-service-extension/README.md Outdated
corinagum
corinagum reviewed Jun 5, 2020
View reviewed changes
Comment thread samples/01.getting-started/i.protocol-direct-line-app-service-extension/README.md Outdated
corinagum
corinagum reviewed Jun 5, 2020
View reviewed changes
Comment thread __tests__/html/offlineUI.sendFailed.noAck.html Outdated
@compulim compulim merged commit ac70fc9 into microsoft:master Jun 8, 2020
@compulim compulim deleted the feat-dlase branch June 8, 2020 13:53
@compulim compulim mentioned this pull request Jun 10, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@ckkashyap ckkashyap Awaiting requested review from ckkashyap

@swagatmishra2007 swagatmishra2007 Awaiting requested review from swagatmishra2007

1 more reviewer

@corinagum corinagum corinagum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Direct Line App Service Extension protocol

2 participants

@compulim @corinagum