Bump to [email protected] and disable tabindex#3193
Merged
compulim merged 5 commits intomicrosoft:masterfrom Jun 3, 2020
Merged
Bump to [email protected] and disable tabindex#3193compulim merged 5 commits intomicrosoft:masterfrom
compulim merged 5 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
beyackle,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
approved these changes
Jun 3, 2020
This was referenced Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1340.
Changelog Entry
Fixed
tapAction, by @compulim in PR #3193Changed
[email protected]Description
Card container should not be focusable (no
tabIndex="0") if they do not havetapAction. This requires bumping to Adaptive Cards 1.2.6 plus a global settings.Specific Changes
[email protected]AdaptiveCards.GlobalSettings.setTabIndexAtCardRoottotrueif the card hastapActionprop, otherwisefalse